Merge latest RUC LSM into community develop and add new soil/veg data #633
Conversation
|
Hi Tanya, I believe that field already existed. The snow fields I added are tsnowp and tsnowpbEric
-------- Original message --------From: tanyasmirnova ***@***.***> Date: 3/9/23 12:40 PM (GMT-05:00) To: NOAA-EMC/fv3atm ***@***.***> Cc: ericaligo-NOAA ***@***.***>, Mention ***@***.***> Subject: Re: [NOAA-EMC/fv3atm] Draft: Merge latest RUC LSM into community develop and add new soil/veg data (PR #633)
@tanyasmirnova commented on this pull request.
In ccpp/driver/GFS_diagnostics.F90:
@@ -1823,12 +1824,11 @@ subroutine GFS_externaldiag_populate (ExtDiag, Model, Statein, Stateout, Sfcprop
idx = idx + 1
ExtDiag(idx)%axes = 2
- ExtDiag(idx)%name = 'totsnwb_ave'
- ExtDiag(idx)%desc = 'bucket surface snow precipitation rate'
- ExtDiag(idx)%unit = 'kg/m**2/s'
+ ExtDiag(idx)%name = 'totsnwb'
@ericaligo-NOAA I only removed time-averaging of buckets, as it seems confusing. Are you sure you want to keep time-averaging and existing description for precipitation buckets?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
I don't believe RRFS has any use for it, but I'm not sure about global
applications.
…On 3/9/2023 1:29 PM, tanyasmirnova wrote:
***@***.**** commented on this pull request.
------------------------------------------------------------------------
In ccpp/driver/GFS_diagnostics.F90
<#633 (comment)>:
> @@ -1823,12 +1824,11 @@ subroutine GFS_externaldiag_populate (ExtDiag, Model, Statein, Stateout, Sfcprop
idx = idx + 1
ExtDiag(idx)%axes = 2
- ExtDiag(idx)%name = 'totsnwb_ave'
- ExtDiag(idx)%desc = 'bucket surface snow precipitation rate'
- ExtDiag(idx)%unit = 'kg/m**2/s'
+ ExtDiag(idx)%name = 'totsnwb'
@ericaligo-NOAA <https://github.com/ericaligo-NOAA> @junwang-noaa
<https://github.com/junwang-noaa> Are we going to keep time-averaging
of precipitation buckets? It does not make sense to me.
—
Reply to this email directly, view it on GitHub
<#633 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQ75MJORCQVNLNMM3XQQRDW3IOO3ANCNFSM6AAAAAAVUK5HMU>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
precipitation buskets. Also, restored time-averaged snow cover fraction and added instantaneous snow cover fraction.
tanyasmirnova
changed the title
…t_assuming_variable_snow_density_over_land
|
Tests are complete on #1646, how is the review coming along on this PR? @junwang-noaa @SamuelTrahanNOAA |
|
ufs-community/ccpp-physics#49 has been merged. @tanyasmirnova Please revert the changes to the .gitmodules file, pull down the latest ufs/dev branch of https://github.com/ufs-community/ccpp-physics that contains the merged code and |
jkbk2004
requested review from
DusanJovic-NOAA,
BrianCurtis-NOAA and
junwang-noaa
|
@SamuelTrahanNOAA Sam, could you please revert the changes to .gitmodules file as Grant described? |
|
This branch points to the ufs/dev branch of ccpp-physics and the .gitmodules has been reverted. You can commit now. |
|
@SamuelTrahanNOAA Thank you, Sam. |
|
Thanks @SamuelTrahanNOAA. Sorry for bugging you about it @tanyasmirnova -- I didn't realize Sam was handling this for you. |
|
@grantfirl No problem, Grant. |
|
@DusanJovic-NOAA @BrianCurtis-NOAA @junwang-noaa please, go ahead to review and approve the pr. |
Description
This PR merges changes from RRFS_dev to UFS community develop related to:
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR?
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs